Cleanup - break positional requirement of keywords #23343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2025 16:26
Perl_coresub_op generating OPs for __FILE__, __LINE__, and __PACKAGE__ keywords relied on the exact order of their codes, introducing a dependency between parser and runtime by using magic transformation of keyword code to index into the return list of `OP_CALLER`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper behaviour of
op.cdepended on correct keyword order inregen/keywords.pl.Affected logic was fragile and magic (
% 3).Change breaks such requirement, allowing alphabetical sorting (always improving maintenance).
t/op/coreamp.tThis set of changes does not require a perldelta entry.
Follow-ups
+and another-PPIto project changes tolib/B/Deparse.pm