Improve -DNO_SHORT_NAMES handling #23812
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple change makes the perl core compile even with this flag.
Prior to this commit, a commented-out prototype was created for all macros that we have argument and return type information for. This might be useful information for a reader of proto.h. This commits stops doing this for private macros. It makes a future commit slightly easier, and I'm unsure of the usefulness of this anyway. But I could be persuaded otherwise.
Where 'weird' is defined as meaning something that the normal rules don't apply, so something we generate is unlikely to be correct. This only affects one element, and it uses aTHX in a way that is incompatible with it being automated.
khwilliamson
force-pushed
the
longnames
branch
from
3616f58 to
8c553c0
Compare
This option has been broken for a long time, but this commit goes a long way to fixing that. It works by creating a new file long_names.c that is automatically generated by regen/embed.pl. This file contains the API elements that normally are macros that don't have a separate long name. when NO_SHORT_NAMES is defined, those macros are suppressed, and instead the long-name functions in this file get compiled The next yak (maybe the only one) needing to be shaved after this is inline functions that use short names. Since they currently are included in the user space, those short names need to be defined, but we'rev compiling without short names, so it doesn't work. We could require inline functions to use long names, but I don't like that, and I suspect you don't either. To me, the easiest other option is to just not have inline functions outside the core when short names are forbidden. We could easily convert them from being inline, and only include them from long_names.c. Thus they would become like any other function in the file.
khwilliamson
force-pushed
the
longnames
branch
from
8c553c0 to
5e195c6
Compare
|
I like the idea of this, I'm not sure the details are right. In particular, it seems to be treating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option has been broken for a long time, but this p.r. goes a long way to fixing that.
It works by creating a new file
long_names.cthat is automatically generated byregen/embed.pl. This file contains the API elements that normally are macros that don't have a separate long name. when NO_SHORT_NAMES is defined, those macros are suppressed, and instead the long-name functions in this file get compiledThe next yak (maybe the only one) needing to be shaved after this is inline functions that use short names. Since they currently are included in the user space, those short names need to be defined, but we're compiling without short names, so it doesn't work.
We could require inline functions to use long names, but I don't like that, and I suspect you don't either.
To me, the easiest other option is to just not have inline functions outside the core when short names are forbidden. We could easily convert them from being inline, and only include them from long_names.c. Thus they would become like any other function in the file.