-
Notifications
You must be signed in to change notification settings - Fork 1
[PER-10370] Archive icon should redirect to account workspace #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 47.15% 47.14% -0.02%
==========================================
Files 372 372
Lines 11495 11492 -3
Branches 1912 1912
==========================================
- Hits 5421 5418 -3
+ Misses 5889 5887 -2
- Partials 185 187 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Meta note: for PRs that are branches based on a non-main branch you can actually specify the other branch as the base. This means the PR will only show the new commits. It's important NOT to merge in this case, since it will ultimately merge into that non-main branch if you do so, but this makes the review itself easier! I made that change (so now this PR has fewer diff lines) |
6204ad0 to
ab652c2
Compare
slifty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it says on the tin!
|
(I changed the base back to main for this case just because the original branch needed to be rebased to allow for QA) |
When a user views an unlisted share while logged in, the person can click the thumbnail and be redirected to his current archive. Issue: PER-10370 Archive icon should redirect to account workspace archive thumbnail and he
f6909ca to
c896a6e
Compare
Task: https://permanent.atlassian.net/browse/PER-10370
HOW TO TEST:
EXPECTATION: Should be redirected to the logged in user's current archive