Skip to content

Conversation

@aasandei-vsp
Copy link
Contributor

@aasandei-vsp aasandei-vsp commented Dec 11, 2025

Task: https://permanent.atlassian.net/browse/PER-10370

HOW TO TEST:

  1. Create an account or use an existing one
  2. Create an unlisted share
  3. Open a new window and log in to a different account
  4. Paste the unlisted share link
  5. Click the logged in user archive icon
    EXPECTATION: Should be redirected to the logged in user's current archive

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.14%. Comparing base (3f01b5e) to head (c896a6e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #858      +/-   ##
==========================================
- Coverage   47.15%   47.14%   -0.02%     
==========================================
  Files         372      372              
  Lines       11495    11492       -3     
  Branches     1912     1912              
==========================================
- Hits         5421     5418       -3     
+ Misses       5889     5887       -2     
- Partials      185      187       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slifty slifty changed the base branch from main to PER-10357-fallback-for-share-token December 12, 2025 20:08
@slifty
Copy link
Contributor

slifty commented Dec 12, 2025

Meta note: for PRs that are branches based on a non-main branch you can actually specify the other branch as the base. This means the PR will only show the new commits.

It's important NOT to merge in this case, since it will ultimately merge into that non-main branch if you do so, but this makes the review itself easier!

I made that change (so now this PR has fewer diff lines)

@cecilia-donnelly cecilia-donnelly force-pushed the PER-10357-fallback-for-share-token branch from 6204ad0 to ab652c2 Compare December 12, 2025 20:09
Copy link
Contributor

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin!

@slifty slifty changed the base branch from PER-10357-fallback-for-share-token to main December 12, 2025 20:15
@slifty
Copy link
Contributor

slifty commented Dec 12, 2025

(I changed the base back to main for this case just because the original branch needed to be rebased to allow for QA)

When a user views an unlisted share while logged in, the person
can click the thumbnail and be redirected to his current archive.

Issue: PER-10370 Archive icon should redirect to account workspace
archive thumbnail and he
@aasandei-vsp aasandei-vsp force-pushed the PER-10370-redirect-to-current-archive branch from f6909ca to c896a6e Compare December 15, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants