Fix noninteractive tty stream constructors - #2136
Merged
proggeramlug merged 1 commit intoMay 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tty.ReadStream/tty.WriteStreamconstructor calls withSystemError/ERR_TTY_INIT_FAILED0from making anonymous objects satisfyinstanceofchecks such asprocess.stdout instanceof tty.WriteStreamVerification
node-suite/tty: 29 pass / 2 fail, reporttest-parity/reports/parity_report_20260527_210503.json./run_parity_tests.sh --suite node-suite --module tty/classes --filter color-depth-envPASS, reporttest-parity/reports/parity_report_20260527_211100.json./run_parity_tests.sh --suite node-suite --module tty/classes --filter readstream-constructor-errorsPASS, reporttest-parity/reports/parity_report_20260527_211101.json./run_parity_tests.sh --suite node-suite --module ttyPASS 31/31, reporttest-parity/reports/parity_report_20260527_211231.jsoncargo test -p perry-runtime --lib tty -- --nocapturePASS (existing warnings only)cargo test -p perry-runtime --lib instanceof -- --nocapturePASS, 0 matching tests (existing warnings only)cargo fmt --checkgit diff --checkDeepWiki
reference/deepwiki/nodejs-node-tty-noninteractive-stream-constructors-2026-05-27.md(local-only reference, not staged)Non-goals
net.Socketstream implementationinstanceofrefactor beyond guarding class id0Closes #793