Skip to content

fix(compile): #5984 — computed-key static fields leak synthetic name into cross-module externs #5985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 2 commits into from
Jul 5, 2026
Merged

fix(compile): #5984 — computed-key static fields leak synthetic name into cross-module externs #5985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97e359c
fix(compile): #5984 — computed-key static fields leak synthetic name …
Jul 4, 2026
8de46fe
cases(#5984): computed-key static field cross-module regression fixture
Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/perry/src/commands/compile/run_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2437,6 +2437,7 @@ pub fn run_with_parse_cache(
static_field_names: class
.static_fields
.iter()
.filter(|f| f.key_expr.is_none())
.map(|f| f.name.clone())
.collect(),
getter_names: class
Expand Down Expand Up @@ -2745,6 +2746,7 @@ pub fn run_with_parse_cache(
static_field_names: class
.static_fields
.iter()
.filter(|f| f.key_expr.is_none())
.map(|f| f.name.clone())
.collect(),
getter_names: class
Expand Down Expand Up @@ -3019,6 +3021,7 @@ pub fn run_with_parse_cache(
static_field_names: class
.static_fields
.iter()
.filter(|f| f.key_expr.is_none())
.map(|f| f.name.clone())
.collect(),
getter_names: class
Expand Down Expand Up @@ -3086,6 +3089,7 @@ pub fn run_with_parse_cache(
static_field_names: class
.static_fields
.iter()
.filter(|f| f.key_expr.is_none())
.map(|f| f.name.clone())
.collect(),
getter_names: class.getters.iter().map(|(n, _)| n.clone()).collect(),
Expand Down Expand Up @@ -3244,6 +3248,7 @@ pub fn run_with_parse_cache(
static_field_names: class
.static_fields
.iter()
.filter(|f| f.key_expr.is_none())
.map(|f| f.name.clone())
.collect(),
getter_names: class.getters.iter().map(|(n, _)| n.clone()).collect(),
Expand Down Expand Up @@ -3717,6 +3722,7 @@ pub fn run_with_parse_cache(
static_field_names: class
.static_fields
.iter()
.filter(|f| f.key_expr.is_none())
.map(|f| f.name.clone())
.collect(),
getter_names: class.getters.iter().map(|(n, _)| n.clone()).collect(),
Expand Down Expand Up @@ -3916,6 +3922,7 @@ pub fn run_with_parse_cache(
static_field_names: class
.static_fields
.iter()
.filter(|f| f.key_expr.is_none())
.map(|f| f.name.clone())
.collect(),
getter_names: class.getters.iter().map(|(n, _)| n.clone()).collect(),
Expand Down
8 changes: 8 additions & 0 deletions test-files/fixtures/issue_5984_pkg/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { entityKind } from "./entity.ts";

export abstract class BaseSession {
static readonly [entityKind]: string = "BaseSession";
tag(): string {
return "base";
}
}
1 change: 1 addition & 0 deletions test-files/fixtures/issue_5984_pkg/entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const entityKind: unique symbol = Symbol.for("entityKind");
13 changes: 13 additions & 0 deletions test-files/test_issue_5984_computed_static_field_cross_module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { entityKind } from "./fixtures/issue_5984_pkg/entity.ts";
import { BaseSession } from "./fixtures/issue_5984_pkg/base.ts";

class EffectSession extends BaseSession {
static override readonly [entityKind]: string = "EffectSession";
tag(): string {
return "effect";
}
}

console.log((BaseSession as any)[entityKind]);
console.log((EffectSession as any)[entityKind]);
console.log(new EffectSession().tag());
Loading