Skip to content

[Minor] Try fix another path finding crash #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Coronia merged 1 commit into from
Sep 6, 2025
Merged

[Minor] Try fix another path finding crash #1840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Misc/Hooks.BugFixes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2505,7 +2505,7 @@ DEFINE_HOOK(0x6FC8F5, TechnoClass_CanFire_SkipROF, 0x6)

#pragma region AStarBuffer

// AStarClass_CTOR
// AStarClass::CTOR
// Path queue nodes buffer doubled

// 42A74F: 68 04 00 04 00
Expand All @@ -2528,4 +2528,17 @@ DEFINE_PATCH(0x42A7E3, 0x20);
DEFINE_PATCH(0x42A7FA, 0x02);
// mov edx, 10000h (65536) -> mov edx, 20000h (131072)

// AStarClass::FindHierarchicalPath
// Replace sign-extend to zero-extend

// 42C34A: 0F BF 1C 70
// To avoid incorrect negative int index
DEFINE_PATCH(0x42C34B, 0xB7);
// movsx ebx, word ptr [eax+esi*2] -> movzx ebx, word ptr [eax+esi*2]

// 42C36A: 0F BF 04 70
// To avoid incorrect negative int index
DEFINE_PATCH(0x42C36B, 0xB7);
// movsx eax, word ptr [eax+esi*2] -> movzx eax, word ptr [eax+esi*2]

#pragma endregion
Loading