Skip to content

Conversation

@CrimRecya
Copy link
Contributor

  • Fix an issue that the currently hovered planning node not update up-to-date, such as using hotkeys to select technos

    修复高等路径学

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Otamaa
Copy link
Contributor

Otamaa commented Sep 8, 2025

Can you please wrote it on human readable way , this will make thing hard to review because not everyone understand ASM stuffs .

@CrimRecya
Copy link
Contributor Author

Can you please wrote it on human readable way , this will make thing hard to review because not everyone understand ASM stuffs .

Changed.

@secsome
Copy link
Member

secsome commented Sep 9, 2025

This seem harder to read than the assembly one in fact. The code just added an extra cmp but reading this PR makes me compare it for a long time. I suppose the asm one with detailed comment would be nicer. dunno how does the other think

@Starkku
Copy link
Contributor

Starkku commented Sep 11, 2025

Code is readable enough now, just needs to be tested ingame I guess.

@Coronia Coronia added Tested ⚙️T1 T1 maintainer review is sufficient and removed Needs testing labels Sep 12, 2025
@CrimRecya CrimRecya merged commit 6830e1f into Phobos-developers:develop Sep 12, 2025
18 checks passed
@CrimRecya CrimRecya deleted the develop-PlanningNodeConnect branch September 12, 2025 05:11
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants