[Minor] Fix create building map trigger action #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Minor
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
it works |
Starkku
force-pushed
the
fix/create-building
branch
from
9b8e734 to
638d6a3
Compare
Metadorius
removed
the
Minor
Member
|
Since the bug has been there for a long time, it shouldn't be tagged with minor |
Starkku
added
the
Bugfix
Coronia
approved these changes
Sep 12, 2025
DeathFishAtEase
added a commit
to DeathFishAtEase/Phobos
that referenced
this pull request
Sep 12, 2025
Metadorius
pushed a commit
that referenced
this pull request
Oct 7, 2025
Fixes an issue with map trigger action 125 causing buildups to play incorrectly sometimes. A separate issue remains where any building that is mid-buildup will interrupt buildup if it changes owner but this is not exclusive to buildings created through the trigger action. Also re-enabled use fo the third parameter but this time it turns buildups off even if otherwise available if set to != 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with map trigger action 125 causing buildups to play incorrectly sometimes. A separate issue remains where any building that is mid-buildup will interrupt buildup if it changes owner but this is not exclusive to buildings created through the trigger action.
Also re-enabled use fo the third parameter but this time it turns buildups off even if otherwise available if set to != 0.