Skip to content

fix: replace unstable list keys and fix burn page build errors#293

Merged
Junman140 merged 10 commits into
Pi-Defi-world:mainfrom
temisan0x:fix/F-044-unstable-list-keys
Apr 27, 2026
Merged

fix: replace unstable list keys and fix burn page build errors#293
Junman140 merged 10 commits into
Pi-Defi-world:mainfrom
temisan0x:fix/F-044-unstable-list-keys

Conversation

@temisan0x
Copy link
Copy Markdown
Contributor

Closes #215

Summary

Replaces unstable React list keys across affected components and resolves build-breaking issues in the Burn page discovered during implementation.

What changed

Stable key fixes

  • Added unique id values for FAQ items in app/help/page.tsx
  • Replaced index-based keys in signup password strength indicators
  • Updated field.tsx, skeleton-list.tsx, and slider.tsx to avoid key={index}
  • Confirmed rates/page.tsx and mint/page.tsx already use stable identifiers

Burn page fixes

  • Fixed broken JSX structure from unmatched tags
  • Replaced invalid values references with form.getValues()
  • Corrected submit handler from formHandleSubmit to form.handleSubmit

Verification

  • Removed unstable key={index} usage in affected files
  • tsc --noEmit passes
  • Burn page now builds successfully without JSX/TS errors

Testing

  • Confirmed FAQ and rate card rendering remains stable
  • Verified Burn page form loads and submits correctly

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5a19002f-bcb4-4d6f-b1e9-d0250c200682

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Junman140
Copy link
Copy Markdown
Member

@temisan0x resolve conflicts

@temisan0x
Copy link
Copy Markdown
Contributor Author

Fixed the conflicts and synced everything with the latest main. Also cleaned up the package-lock and double-checked the burn page logic so it’s all good to go now. Ready for review whenever you're free! @Junman140

@Junman140
Copy link
Copy Markdown
Member

@temisan0x it still has two

@temisan0x
Copy link
Copy Markdown
Contributor Author

Resolved all conflicts with upstream/main, confirmed no key={index} across the app. Also caught and fixed one in help/page.tsx. Ready for review. @Junman140

@Junman140 Junman140 merged commit c543529 into Pi-Defi-world:main Apr 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants