tests: added GTest to prove line number is recursively correct #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So what ended up being the problem here? |
|
no problem from what I could tell :/ I couldn't reproduce this even with their subtree directly ported in. if you have a repro case that's great, but I just added the unit test so we can monitor if it breaks elsewhere |
shaur-k
force-pushed
the
fix-node-validation
branch
from
c7b467e to
666929c
Compare
shaur-k
force-pushed
the
fix-node-validation
branch
from
666929c to
117e6b6
Compare
shaur-k
force-pushed
the
fix-node-validation
branch
from
117e6b6 to
78e4184
Compare
dyackzan
force-pushed
the
rebase-main-on-master
branch
6 times, most recently
from
bd5ceea to
5d316db
Compare
shaur-k
force-pushed
the
fix-node-validation
branch
from
78e4184 to
f4c4ce8
Compare
dyackzan
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accidentally opened to the wrong place...
adds a test to show that we can ensure that this closes https://github.com/PickNikRobotics/moveit_pro/issues/13168