-
Notifications
You must be signed in to change notification settings - Fork 0
feat: move fineprint to end of goal details output #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: narthur <[email protected]>
Co-authored-by: narthur <[email protected]>
Co-authored-by: narthur <[email protected]>
🚀 Pre-release Build ReadyTest builds are ready! Install directly using the # Install the pre-release
bin install https://github.com/PinePeakDigital/buzz/releases/tag/pr-204-latest buzz-pr-204# Run the pre-release
buzz-pr-204# Uninstall the pre-release
bin remove buzz-pr-204Direct Download LinksOr download binaries directly from the pre-release page:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the readability of goal details output by relocating the Fine print field from its position immediately after Title to the end of the output, appearing after the URL field.
Key changes:
- Moved fineprint display logic in
formatGoalDetails()to render as the last field - Added a dedicated test to verify fineprint appears after URL
- Updated
.gitignoreto excludebuzz_testtest binary
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
review.go |
Relocated fineprint conditional block from after Title (lines 228-232) to after URL (lines 257-260) in formatGoalDetails() |
review_test.go |
Added TestFineprintOrderInOutput test that verifies fineprint appears after URL by comparing string positions |
.gitignore |
Added buzz_test entry to exclude test binaries from version control |
Summary: The implementation is clean and correct. The fineprint logic was properly moved with its conditional check intact, the new test effectively validates the ordering requirement, and the .gitignore change is appropriate. The existing tests for fineprint presence/absence remain valid since they only check for content, not position. No issues found.
Moves the
Fine printfield from its position afterTitleto the end of the goal details output, appearing after theURLfield.Changes
review.go: Relocated fineprint display logic informatGoalDetails()to render after URLreview_test.go: AddedTestFineprintOrderInOutputto verify fineprint positioning.gitignore: Addedbuzz_testto exclude test binariesOutput Format
Before:
After:
Affects both
reviewandviewcommands as they share theformatGoalDetails()function.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.