Conversation
SangChunn
reviewed
Dec 8, 2025
| free (info); | ||
|
|
||
| if (VM_TYPE(page->uninit.type) != VM_FILE) | ||
| free(info); |
Member
There was a problem hiding this comment.
lazy_load_segment는 vm_alloc_page_with_initalizer()로 생성된 UNINIT 페이지가 첫 폴트가 일어날 때만 실행이 되는데 무조건 Type은 UNINIT인 경우만 있지 않나염..?
| return result; | ||
| } | ||
|
|
||
| static void *syscall_mmap(void *addr, size_t length, int writable, int fd, off_t offset) { |
Member
There was a problem hiding this comment.
user address 범위도 체크를 하나 해야하지 않을까.. 싶어요 또한 오버플로우 체크도 해야하지 않을까...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: mmap + munmap