fix: issues Event derive macro on structs with unnamed fields#15
Draft
PiquelChips wants to merge 4 commits intomainfrom
Draft
fix: issues Event derive macro on structs with unnamed fields#15PiquelChips wants to merge 4 commits intomainfrom
Event derive macro on structs with unnamed fields#15PiquelChips wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue where the
Eventderive macro would destructure structs with unnamed fields by creating variables named after ints (like "0"). Now, destructures to names with _ for the names to be acceptable by the compiler. To keep using the indexes in the format message, we append the the variables to the formatting, filtering out indeces that are not specified in the format message.Setup removing subscribers from the event manager if their channel closes.
TODO