Skip to content

feat: Navigate to artist page when clicking on artist name in player UI#1942

Merged
theovilardo merged 1 commit into
PixelPlayerHQ:masterfrom
starry-shivam:master
May 9, 2026
Merged

feat: Navigate to artist page when clicking on artist name in player UI#1942
theovilardo merged 1 commit into
PixelPlayerHQ:masterfrom
starry-shivam:master

Conversation

@starry-shivam

Copy link
Copy Markdown
Contributor
Before After
VID_20260508_230046.mp4
VID_20260508_225443.mp4

Signed-off-by: starry-shivam <touka.krs@gmail.com>
@theovilardo

Copy link
Copy Markdown
Collaborator

Hi! could you explain on which cases it didn't work? cause i tried to replicate it on the latest build and i couldn't

@starry-shivam

Copy link
Copy Markdown
Contributor Author

Hi! could you explain on which cases it didn't work? cause i tried to replicate it on the latest build and i couldn't

It won't work in cases where it can't resolve artistId , it can happen you are playing a song that hasn't been fully synced into the local library (e.g., a "remote-only" search result from Navidrome/Jellyfin that isn't in your "Songs" list yet), the app won't find a corresponding Artist ID. Since the ArtistDetail screen requires a database ID to load, so the navigation will be aborted. I have added a logger call in such cases

Log.d("ArtistDebug", "triggerArtistNavigationFromPlayer: could not resolve artistId for name=${currentSong?.artist}")

So you can check the logs to verify if that's the issue. I had tested it with both local music and after syncing songs from my navidrome server, it worked fine in both cases.

@starry-shivam

starry-shivam commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Btw, I think we should keep albums on the artist page closed by default. Currently, all of them are shown in the expanded state, which imo doesn’t look very nice and wastes space. What do you think? I can push a commit to this PR to change it if you’re okay with that.

@theovilardo theovilardo merged commit bde7457 into PixelPlayerHQ:master May 9, 2026
5 checks passed
@theovilardo

Copy link
Copy Markdown
Collaborator

Btw, I think we should keep albums on the artist page closed by default. Currently, all of them are shown in the expanded state, which imo doesn’t look very nice and wastes space. What do you think? I can push a commit to this PR to change it if you’re okay with that.

I thought the same but that also adds an extra step for the user to have to open the album to play a song, most of them prefer to have the songs already available to play.

@starry-shivam

Copy link
Copy Markdown
Contributor Author

I thought the same but that also adds an extra step for the user to have to open the album to play a song, most of them prefer to have the songs already available to play.

Okay, makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants