Improve natural language in German strings and enhance Lyrics animations#1948
Merged
Conversation
Amonoman
changed the title
Collaborator
|
Hi! there's currently some conflicts with this PR |
- Remove stiff imperative constructions ("Es wird darauf hingewiesen...")
- Replace implicit "Sie" with "du" or impersonal phrasing throughout
- Shorten verbose descriptions in auth, setup, library empty states
- Simplify Cast permission text, Telegram login hints, AI lab labels
- Rephrase error messages to be direct without being harsh
- Add setcat_language_german to settings
…ture (API 34+) Introduces a dedicated PredictiveBackHandler for the Lyrics page that drives a shared Animatable<Float> in real time with the back-swipe gesture progress. Falls back to a plain BackHandler on API < 34. Mirrors the pattern already used by PlayerSheetPredictiveBackHandler.
- Replace plain BackHandler with LyricsPredictiveBackHandler (API 34+ aware) - Animate sheet in on first composition via spring() on backProgress (1f → 0f) - Apply graphicsLayer to Scaffold: scale, alpha, translateY and edge-aware translateX are all driven by the same backProgress Animatable, so the predictive-back gesture shrinks/fades the sheet frame-synchronously - Corner radius lerps from 32 dp → 56 dp during the exit gesture
…ack support Sheet slides down and fades on back gesture (API 34+), falls back to plain BackHandler on older versions. Enter animation spring-slides the sheet in on open. Back button scales and fades in sync with the gesture. - LyricsPredictiveBackHandler.kt: drives progress via Float callback - LyricsSheet.kt: wires up handler, enter anim, graphicsLayer (draw-phase) - LyricsFloatingToolbar.kt: back button animates via backProgressProvider
Restore TransformOrigin and lerp imports removed during cleanup. Qualify lerp calls in graphicsLayer with androidx.compose.ui.util.lerp to prevent shadowing by the Dp overload from androidx.compose.ui.unit.
Sheet now only slides down on predictive back without fading. Back button scales down with a bouncy spring on press, combined with the existing gesture scale via MutableInteractionSource.
Contributor
Author
|
@theovilardo I just rebased the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish & Lyrics Enhancements
This PR improves the PixelPlayer user experience by refining German string naturalness and implementing modern UI animations.
Changes
1. Natural Language (German)
2. Lyrics Animations & Predictive Back (Android 13+)
3. Fixes & Performance