Fix CodeQL alerts and remove green gradients#1982
Merged
Merged
Conversation
Contributor
|
CodeQL seems to fail, please attempt clearing this up if possible. Also test from your end if you have not and let me or @theovilardo know what the status is. |
Collaborator
Author
we never pr before testing, thats the rules here, for codeql, i'm about to fix it. |
Switch sleep-timer Intent construction to the explicit Intent(context, ReceiverClass) form so CodeQL's java/android/implicit-pendingintents rule recognises the target at construction time instead of after a component assignment.
CodeQL data-flow couldn't follow the explicit Intent(context, ReceiverClass) constructor through the separate sleepTimerIntent() helper, so it still flagged the alarmManager.set* calls. Building the Intent in the same function as PendingIntent.getBroadcast matches the pattern that already silenced the alerts in MusicService.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification