refactor: externalize Telegram API credentials to BuildConfig#2056
Merged
Conversation
Removes hardcoded Telegram API credentials from `TelegramClientManager` and moves them to `BuildConfig` fields populated from `local.properties`. This change also updates the device model and version metadata sent to the Telegram API. - Added `TELEGRAM_API_ID` and `TELEGRAM_API_HASH` fields to `build.gradle.kts`. - Updated `TelegramClientManager` to use `BuildConfig` for API identity and application version. - Changed the Telegram client `deviceModel` from the physical device model to "PixelPlayer Instance". - Implemented `local.properties` parsing in the app-level Gradle script to manage sensitive credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes hardcoded Telegram API credentials from
TelegramClientManagerand moves them toBuildConfigfields populated fromlocal.properties. This change also updates the device model and version metadata sent to the Telegram API.TELEGRAM_API_IDandTELEGRAM_API_HASHfields tobuild.gradle.kts.TelegramClientManagerto useBuildConfigfor API identity and application version.deviceModelfrom the physical device model to "PixelPlayer Instance".local.propertiesparsing in the app-level Gradle script to manage sensitive credentials.