feat: enhance MediaStore delete requests and storage volume resolution#2140
Merged
Conversation
Updates `MediaStorePermissionHelper` to improve the reliability of batch deletions and better handle multiple storage volumes on Android 10+. - Added `getAudioMediaStoreUris` to resolve song IDs across all available storage volumes, including `external_primary` and specific volume names. - Introduced `DeleteRequest` data class to track `IntentSender` along with successfully accepted and rejected URIs. - Refactored `createDeleteRequest` to implement a fallback mechanism that filters out invalid URIs causing platform-level failures, allowing partial batch deletes. - Updated `PlayerViewModel` to integrate with the new `DeleteRequest` logic and accurately track skipped items during deletion. - Enhanced `findValidMediaStoreUri` to check for candidates across all discovered volume URIs. - Added unit tests for `external_primary` URI patterns and malformed MediaStore path segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
MediaStorePermissionHelperto improve the reliability of batch deletions and better handle multiple storage volumes on Android 10+.getAudioMediaStoreUristo resolve song IDs across all available storage volumes, includingexternal_primaryand specific volume names.DeleteRequestdata class to trackIntentSenderalong with successfully accepted and rejected URIs.createDeleteRequestto implement a fallback mechanism that filters out invalid URIs causing platform-level failures, allowing partial batch deletes.PlayerViewModelto integrate with the newDeleteRequestlogic and accurately track skipped items during deletion.findValidMediaStoreUrito check for candidates across all discovered volume URIs.external_primaryURI patterns and malformed MediaStore path segments.