Optim/layout calculations and recompositions#2265
Merged
Merged
Conversation
Updates the benchmark suite to cover multiple audio formats and refactors the player sheet layout logic to improve animation stability and prevent jank during transitions. - Added specialized macrobenchmark tests for FLAC, MP3, M4A, and OPUS playlists in `PlayerSheetAnimationBenchmarks`. - Implemented `playFromPlaylist` and navigation helpers in `MacrobenchmarkScope` to automate playlist selection using localized text patterns or coordinate-based fallbacks. - Refactored `UnifiedPlayerSheetV2` layout constraints to use full-screen width measurement during expansion, applying a negative horizontal offset to maintain alignment while preventing layout shifts. - Simplified backstack navigation in `BaselineProfileGenerator` by making `pressBackAndWait` unconditional for optional surfaces. - Expanded UI automation patterns to include localized strings for "Expand menu" and "Playlists" across multiple languages.
Refactors the mini player layout within the unified player sheet to dynamically adjust its width and horizontal position based on expansion progress. This ensures the mini player correctly accounts for screen padding as it transitions to the full player view. - Added `currentHorizontalPaddingStartPxProvider` and `currentHorizontalPaddingEndPxProvider` parameters to the player layer components. - Implemented a custom `.layout` modifier in `UnifiedPlayerSheetLayers.kt` to calculate and apply horizontal offsets and width constraints during expansion. - Used the `playerContentExpansionFraction` to conditionally apply padding, ensuring the mini player maintains its intended width and alignment. - Updated `UnifiedPlayerSheetV2.kt` to pass the padding providers into the player sheet's layer hierarchy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.