Impl/better animations on song info sheet#2302
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c516d40e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| coroutineScope.launch { | ||
| kotlinx.coroutines.delay(180) | ||
| playVisualPressed = false | ||
| clickPending = false | ||
| onPlaySong() |
There was a problem hiding this comment.
When a user taps this action and then dismisses the sheet or switches pages during the 180 ms animation window, this rememberCoroutineScope() job is cancelled as the row leaves composition, so onPlaySong() never runs even though the tap was accepted. The same delayed-dispatch pattern is used for the other sheet actions, so trigger the side effect before the cancellable delay or launch it from a scope that survives the row animation.
Useful? React with 👍 / 👎.
1 participant
No description provided.