Refactor app localization, resource cleanup, and UI localizations#2321
Merged
theovilardo merged 6 commits intoJun 11, 2026
Merged
Conversation
…hour preferences for StatsScreen
Collaborator
|
Hi! There's some conflicts so I can't currently merge this |
Contributor
Author
I'll check it |
Contributor
Author
|
I merged branch master to resolve conflict where file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR focuses on improving and cleaning up the application's localization architecture. It reorganizes string resource files to be more modular/feature-based, refactors core UI components (Navigation, Library Tabs, and Sort Options) to support dynamic localization, and updates time/duration formatting to respect user locales and system 12/24-hour preferences.
Note
The large diff size (~28k insertions, ~30k deletions) is primarily due to the cleanup and migration of string resources from batch-based monolithic files (
strings_presentation_batch_*.xml) to feature-focused resource files (e.g.,strings_home_screen.xml,strings_library.xml).Key Changes
1. String Resource Migration & Modularization
strings_presentation_batch_*.xmlfiles and consolidated translations into modular files such asstrings_home_screen.xml,strings_library.xml,strings_player.xml,strings_settings.xml,strings_equalizer.xml, etc.migrate_presentation_strings.py) used during the transition.2. Navigation, Library Tabs, and Sorting Localization
LibraryTabIdandSortOptiondata models to use resource ID references rather than hardcoded string labels.3. Localized Time, Duration, and 12/24h Prefs
Formats.ktto localize duration and time formatting based on device locale.StatsScreen,StatsOverviewCard).4. UI changes
CollapsibleCommonTopBarandPlaylistContainerwhich were affected by localizationAiMetadataSheet.kt,ExpressiveSongListItem.kt, andSelectionHeader.kt)All changes during the refactoring process have been merged/rebased with master branch and the latest commit.