Fix lyrics translation issues & more localization UI#2332

Merged

theovilardo merged 1 commit into

PixelPlayerHQ:masterfrom

adlifarizi:feature/localization-improvements

Jun 11, 2026

adlifarizi commented Jun 11, 2026 •

edited

Loading

Contributor

Summary

Fix bug where translate lyrics via AI only works for online source lyrics. Fixed by introduced fallback checks in LyricsStateHolder to search for local files, embedded metadata, or database backups when the primary lyrics field is empty.
Replaced hardcoded text in album and genre multi-selection bottom sheets, and the search screen filters with resource strings for localization.

Redesign genre multi-selection bottom sheets to have same design as album mutli-selection for consistency.

Added corresponding translations across supported locales.
Enhanced ToggleSegmentButton with maxLines, overflow, and textAlign, and paddingproperties to prevent text issues in LyricsFloatingToolbar.

Before

After


          feat: externalize more hardcoded strings and fix lyrics translation flow

613f17f

- Localized hardcoded strings in multi-selection sheets and search filter chips.
- Enhanced ToggleSegmentButton to support custom text alignment, maxLines, and overflow.
- Fix AI lyrics translation only works for online source lyrics by checking fallback sources (local, embedded, DB) on Dispatchers.IO.

adlifarizi marked this pull request as draft

June 11, 2026 12:41

adlifarizi changed the title ~~feat: externalize more hardcoded strings and fix lyrics translation flow~~ Fix lyrics translation issues & more localization UI

adlifarizi marked this pull request as ready for review

June 11, 2026 12:53

theovilardo merged commit a3a800e into PixelPlayerHQ:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet