Skip to content

Fix rounding issue for vault_eco_balance_formatted #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix rounding issue for vault_eco_balance_formatted #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ plugins {
}

group = 'at.helpch.placeholderapi.expansion'
version = '1.8.3'
version = '1.8.4-dev'

repositories {
mavenCentral()
Expand All @@ -23,10 +23,10 @@ repositories {
}

dependencies {
compileOnly 'org.spigotmc:spigot-api:1.16.3-R0.1-SNAPSHOT'
compileOnly 'me.clip:placeholderapi:2.11.1'
compileOnly 'org.jetbrains:annotations:23.0.0'
compileOnly 'com.github.MilkBowl:VaultAPI:1.7'
compileOnly 'org.spigotmc:spigot-api:1.21.8-R0.1-SNAPSHOT'
compileOnly 'me.clip:placeholderapi:2.11.6'
compileOnly 'org.jetbrains:annotations:26.0.2'
compileOnly 'com.github.MilkBowl:VaultAPI:1.7.1'
}

compileJava {
Expand Down
10 changes: 8 additions & 2 deletions src/main/java/at/helpch/placeholderapi/expansion/vault/EconomyHook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,15 @@ private double getBalance(@NotNull final OfflinePlayer player) {
final Long divideBy = e.getKey();
final String suffix = e.getValue();

if (divideBy == null || divideBy <= 0) {
return Long.toString(balance); //no suffix found, return as is
}

long truncated = balance / (divideBy / 10); //the number part of the output times 10
boolean hasDecimal = truncated < 100 && (truncated / 10d) != (truncated / 10);
return hasDecimal ? (truncated / 10d) + suffix : (truncated / 10) + suffix;
long decimal = truncated % 10;
truncated /= 10; //remove the decimal part

return decimal == 0 ? truncated + suffix : truncated + "." + decimal + suffix;
}

@Override
Expand Down