This repository was archived by the owner on May 16, 2023. It is now read-only.
Generating ARN strings #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurrentt
reviewed
Oct 3, 2019
| "arn:aws:s3:::my-bucket/*", | ||
| ) | ||
|
|
||
| @given(sampled_from(arn_examples)) |
There was a problem hiding this comment.
I think you can achieve the same kind of functionality using pytest's parametrize without the need to involve a new testing library.
|
@mikedlr no pressure, but are you still interested in contributing to this PR? |
|
Hi; Yes; I've just partly built the open source version of the software which will justify this then I'll complete the patch against the real software. As far as hypothesis goes I want to also do more broad testing of the handling of different messy strings and fuzzing so I think I'll justify using it. In the meantime it's just the quickest way I knew to do what I want. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first run through generating ARNs - adds a
__str__method to the ARN object as discussed in #6