fix(backend): bump cross-chain finalization wait to 2 minutes#287
Closed
gianalarcon wants to merge 1 commit into
Closed
fix(backend): bump cross-chain finalization wait to 2 minutes#287gianalarcon wants to merge 1 commit into
gianalarcon wants to merge 1 commit into
Conversation
zkVerify confirmed proof aggregation now completes within ~2 minutes across supported networks (incl. Arbitrum Sepolia). Raise the post-aggregation finalization wait from 40s to 120s so transactions wait long enough for cross-chain finalization before the receipt poll, reducing premature/stuck executions. Applies uniformly to all chains (Base, Horizen, Arbitrum Sepolia). Also make the log message derive the duration from the constant so it can't drift out of sync again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closing — this change should land via the Arbitrum work on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises
CROSS_CHAIN_FINALIZATION_WAITfrom 40s → 120s (2 min), applied uniformly to all chains (Base, Horizen, Arbitrum Sepolia).Why
The zkVerify team confirmed proof aggregation now completes within ~2 minutes across supported networks, including Arbitrum Sepolia (previously slower). The executor waits this duration after a recent aggregation before polling for the cross-chain receipt; 40s was too short for the aggregation-to-finalization window, risking premature/stuck executions. 2 minutes matches the observed aggregation time.
Changes
packages/backend/src/common/constants/timing.ts—CROSS_CHAIN_FINALIZATION_WAIT40_000→120_000.packages/backend/src/transaction/transaction-executor.service.ts— log message now derives the duration from the constant (${CROSS_CHAIN_FINALIZATION_WAIT / 1000}s) instead of a hardcoded "40s", so it can't drift.Notes
Validation
node_modulesin this checkout, so localtsc/build not run. Change is a constant value + a log-string interpolation; CIyarn build(lint.yaml) will compile-check.🤖 Generated with Claude Code