Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

add a status 'undefined' for horizontalAlign and verticalAlign#97

Open
hzmsrv wants to merge 2 commits into
PolymerElements:masterfrom
hzmsrv:master
Open

add a status 'undefined' for horizontalAlign and verticalAlign#97
hzmsrv wants to merge 2 commits into
PolymerElements:masterfrom
hzmsrv:master

Conversation

@hzmsrv
Copy link
Copy Markdown

@hzmsrv hzmsrv commented Nov 2, 2018

sometimes we only need the element to drop down without any style like top, width, height...

the default will change those styles directly on the element. it is top level and change in runtime.

so we add this undefined to stop changing.

@hzmsrv hzmsrv requested a review from bicknellr as a code owner November 2, 2018 07:31
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@hzmsrv
Copy link
Copy Markdown
Author

hzmsrv commented Nov 2, 2018 via email

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants