Polymesh v8 next features #1861
Open
+1,615
−459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neopallium
force-pushed
the
polymesh-v8-next-features
branch
from
03a8b16 to
c8e66a0
Compare
Neopallium
force-pushed
the
polymesh-v8-next-features
branch
2 times, most recently
from
f2c5740 to
650315a
Compare
Neopallium
changed the base branch from
develop_v8
to
refactor_transaction_payment
Neopallium
force-pushed
the
polymesh-v8-next-features
branch
2 times, most recently
from
94d140c to
e88cbbb
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Neopallium
requested review from
F-OBrien,
HenriqueNogara,
Copilot and
martinhalford
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR introduces significant v8 features to the Polymesh blockchain node, focusing on adding BEEFY consensus protocol support, MMR (Merkle Mountain Range) for efficient proof generation, and transaction extension improvements to support generic Ledger hardware wallet applications.
Key Changes:
- Adds BEEFY, BEEFY MMR, and MMR pallets for enhanced finality proof generation
- Introduces new transaction extensions: AuthorizeCall, CheckNonZeroSender, WeightReclaim, and CheckMetadataHash
- Implements a data migration to upgrade SessionKeys with placeholder BEEFY keys for existing validators
Reviewed changes
Copilot reviewed 30 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/service.rs | Integrated BEEFY and MMR services, added hardware benchmarking, new test helper functions |
| src/command.rs | Updated CLI implementation version to use new environment variable |
| src/cli.rs | Enhanced CLI with BEEFY and hardware benchmark flags, added new subcommands |
| src/lib.rs | New library entry point created to support modular architecture |
| src/bin/main.rs | New binary entry point replacing src/main.rs |
| pallets/runtime/common/src/runtime.rs | Added BEEFY/MMR pallet configs, SessionKeys migration, new transaction extensions |
| pallets/runtime/*/src/runtime.rs | Added BEEFY, MMR, and MmrLeaf pallets to all runtimes |
| pallets/runtime/*/Cargo.toml | Added dependencies for BEEFY, MMR, and metadata hash extension |
| node-rpc/src/lib.rs | Integrated BEEFY and MMR RPC endpoints |
| src/chain_spec/*.rs | Updated session key generation to include BEEFY keys |
| Cargo.toml | Added BEEFY/MMR dependencies, new feature flags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Neopallium
force-pushed
the
polymesh-v8-next-features
branch
from
e1d3af1 to
a190269
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 33 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog
new features
modified external API
other
on-chain-release-buildto our runtimes to shrink the runtimes (about 1M from uncompressed size) for release builds.data migration
SessionKeysto add a placeholder BEEFY key (The key is not valid, validators will need to rotate their keys) for all validators.