Skip to content

chore: improve eslint rule #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

chore: improve eslint rule #2038

merged 1 commit into from
Jun 25, 2025

Conversation

pauldambra
Copy link
Member

#1980 is going to be messy to update in the new workspace

let's see if we can chop it up to make life easier

Copy link

vercel bot commented Jun 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jun 25, 2025 9:54am

@pauldambra pauldambra requested a review from a team June 25, 2025 09:51
@pauldambra pauldambra enabled auto-merge (squash) June 25, 2025 09:51
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the ESLint rule for external replay imports to be more precise in path validation, specifically requiring 'replay/external' instead of just 'external' in relative paths.

  • Modified eslint-rules/no-external-replay-imports.js to enforce stricter path validation
  • Change prevents false positives from unrelated paths containing 'external'
  • Aligns relative path checking with existing absolute path requirements
  • Makes the rule more accurate for the upcoming workspace changes

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link

Copy link

Size Change: 0 B

Total Size: 3.56 MB

ℹ️ View Unchanged
Filename Size
packages/browser/dist/all-external-dependencies.js 220 kB
packages/browser/dist/array.full.es5.js 306 kB
packages/browser/dist/array.full.js 371 kB
packages/browser/dist/array.full.no-external.js 388 kB
packages/browser/dist/array.js 171 kB
packages/browser/dist/array.no-external.js 186 kB
packages/browser/dist/customizations.full.js 15.9 kB
packages/browser/dist/dead-clicks-autocapture.js 12.6 kB
packages/browser/dist/exception-autocapture.js 9.55 kB
packages/browser/dist/external-scripts-loader.js 2.57 kB
packages/browser/dist/main.js 172 kB
packages/browser/dist/module.full.js 371 kB
packages/browser/dist/module.full.no-external.js 388 kB
packages/browser/dist/module.js 171 kB
packages/browser/dist/module.no-external.js 186 kB
packages/browser/dist/posthog-recorder.js 207 kB
packages/browser/dist/recorder-v2.js 113 kB
packages/browser/dist/recorder.js 113 kB
packages/browser/dist/surveys-preview.js 70.7 kB
packages/browser/dist/surveys.js 78.8 kB
packages/browser/dist/tracing-headers.js 1.63 kB
packages/browser/dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra merged commit a380789 into main Jun 25, 2025
30 checks passed
@pauldambra pauldambra deleted the chore/fix-eslint-rule branch June 25, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants