chore(migration): add linting config #2043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Major updates to linting configuration across the posthog-js monorepo as part of the posthog-js-lite migration effort, introducing potential consistency issues and disabled rules that warrant attention.
- Inconsistent
tabWidthsettings across packages (2 spaces vs 4 spaces in root), potentially leading to formatting discrepancies - Disabled important linting rules in
.eslintrc.jsincluding type checking and console restrictions could impact code quality - Added
.nvmrcspecifying Node.js version 20 for consistent development environments - Consolidated package-specific linting into a single
pnpm lintcommand in CI workflow - Added individual
.prettierrcfiles to packages (web, node, nextjs-config, etc.) with potentially conflicting configurations
23 files reviewed, 8 comments
Edit PR Review Bot Settings | Greptile
hpouillot
commented
Jun 25, 2025
| 'no-console': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'off', | ||
| '@typescript-eslint/naming-convention': 'off', | ||
| 'posthog-js/no-direct-undefined-check': 'off', |
There was a problem hiding this comment.
we should probably clean linting after merging. posthog-js rules should only apply to posthog-js package
hpouillot
commented
Jun 25, 2025
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "trailingComma": "es5", | |||
| "tabWidth": 2, | |||
There was a problem hiding this comment.
we don't have the same tabWidth between posthog-js and posthog-js-lite. I will keep it inconsistent for now, to avoid too many file changes
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base PR: #2042
Changes