Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
ca431b5
unifying some types
dmarticus Oct 15, 2024
e89f169
in progress but not done yet
dmarticus Oct 15, 2024
4f20e07
Merge branch 'master' into feat/static-cohorts-rust
dmarticus Oct 23, 2024
ed00224
oh lol right let's actually ship
dmarticus Oct 23, 2024
fb8aab8
or default
dmarticus Oct 23, 2024
899a99c
Merge branch 'master' into feat/dynamic-cohorts-rust
dmarticus Oct 24, 2024
896c31a
Merge branch 'master' into feat/dynamic-cohorts-rust
dmarticus Oct 24, 2024
eeea8cc
let's goooo
dmarticus Oct 24, 2024
d02baec
Merge branch 'feat/dynamic-cohorts-rust' of github.com:PostHog/postho…
dmarticus Oct 24, 2024
39dad2d
Merge branch 'master' into feat/dynamic-cohorts-rust
dmarticus Oct 24, 2024
db8cd8d
modeled the data correctly this time :sweat:
dmarticus Oct 24, 2024
43cda76
clippy my frickin GUY
dmarticus Oct 24, 2024
8d2ab85
some light renaming
dmarticus Oct 25, 2024
9ccf479
yeah
dmarticus Oct 25, 2024
797adbe
remove printlns
dmarticus Oct 25, 2024
71def67
add note about not handling groups
dmarticus Oct 28, 2024
27af814
saving a working version that supports caching, since this is the rig…
dmarticus Oct 29, 2024
4c49bc4
new life
dmarticus Oct 30, 2024
d4af2f0
clippy u dawg
dmarticus Oct 30, 2024
870f719
traverse the dependency graph post-cache access
dmarticus Oct 31, 2024
57d9885
cleaning up
dmarticus Oct 31, 2024
9eb0f18
adding more tests
dmarticus Oct 31, 2024
3cfc590
test for the cohort cache
dmarticus Oct 31, 2024
3e8e5d2
a few things
dmarticus Oct 31, 2024
3528b31
Merge branch 'master' into feat/dynamic-cohorts-rust
dmarticus Oct 31, 2024
d7f9fc0
tests
dmarticus Oct 31, 2024
77059f3
Merge branch 'master' into feat/dynamic-cohorts-rust
dmarticus Nov 1, 2024
09317c4
use global cohort cache
dmarticus Nov 1, 2024
43e8692
less yapping
dmarticus Nov 1, 2024
7a91ada
Merge branch 'master' into feat/static-cohorts-rust-with-caching
dmarticus Nov 1, 2024
70afc65
resolving merge conflicts
dmarticus Nov 1, 2024
6188eb9
static matching too
dmarticus Nov 2, 2024
3a65683
appeasing the linter
dmarticus Nov 2, 2024
92991d3
Merge branch 'feat/dynamic-cohorts-rust' into feat/static-cohorts-rus…
dmarticus Nov 2, 2024
7c3bf83
appeasing the compiler
dmarticus Nov 2, 2024
a5812e6
that should do it
dmarticus Nov 2, 2024
4c1ecc0
Merge branch 'feat/dynamic-cohorts-rust' into feat/static-cohorts-rus…
dmarticus Nov 2, 2024
a1af6ab
just a bit
dmarticus Nov 4, 2024
fd52b24
clean up
dmarticus Nov 4, 2024
59f7c10
rename
dmarticus Nov 4, 2024
8066aff
bit more
dmarticus Nov 4, 2024
3e4f52c
Merge branch 'feat/dynamic-cohorts-rust' into feat/static-cohorts-rus…
dmarticus Nov 4, 2024
4d5ecd9
collapse condition
dmarticus Nov 4, 2024
5ad28a2
Merge branch 'feat/dynamic-cohorts-rust' into feat/static-cohorts-rus…
dmarticus Nov 4, 2024
61788d6
clean up
dmarticus Nov 4, 2024
4012ebe
Merge branch 'master' into feat/dynamic-cohorts-rust
dmarticus Nov 4, 2024
8ededb1
resolve conflicts
dmarticus Nov 6, 2024
fe37b04
working on it
dmarticus Nov 7, 2024
bc38940
Merge branch 'feat/dynamic-cohorts-rust' of github.com:PostHog/postho…
dmarticus Nov 7, 2024
41d3db3
not this either
dmarticus Nov 7, 2024
0a409f4
docs
dmarticus Nov 7, 2024
b6a8b03
test are failing locally but I want to push these changes up to see t…
dmarticus Nov 7, 2024
abdcc0f
use person ID, but the tests are failing
dmarticus Nov 7, 2024
45b145c
lit this works
dmarticus Nov 8, 2024
5f367ce
small cleanup
dmarticus Nov 8, 2024
7807545
no dead code
dmarticus Nov 8, 2024
0dd1c0b
Merge branch 'master' into feat/dynamic-cohorts-rust
dmarticus Nov 15, 2024
e471241
Merge branch 'feat/dynamic-cohorts-rust' into feat/static-cohorts-rus…
dmarticus Nov 15, 2024
4ed42e2
resolve merge conflicts
dmarticus Nov 15, 2024
863f4cf
Merge branch 'feat/static-cohorts-rust-with-caching' of github.com:Po…
dmarticus Nov 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rust/feature-flags/src/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ pub enum FlagError {
CohortFiltersParsingError,
#[error("Cohort dependency cycle")]
CohortDependencyCycle(String),
#[error("Person not found")]
PersonNotFound,
}

impl IntoResponse for FlagError {
Expand Down Expand Up @@ -212,6 +214,9 @@ impl IntoResponse for FlagError {
tracing::error!("Cohort dependency cycle: {}", msg);
(StatusCode::BAD_REQUEST, msg)
}
FlagError::PersonNotFound => {
(StatusCode::BAD_REQUEST, "Person not found. Please check your distinct_id and try again.".to_string())
}
}
.into_response()
}
Expand Down
Loading
Loading