Skip to content

Remove use of atty crate #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025
Merged

Conversation

SteveL-MSFT
Copy link
Member

PR Summary

Remove use of atty crate, update version of crossterm

@SteveL-MSFT SteveL-MSFT requested a review from tgauth July 25, 2025 17:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dependency on the atty crate and migrates to using crossterm's built-in TTY detection functionality, while also updating crossterm to version 0.29.

  • Remove atty crate dependency from two Cargo.toml files
  • Update crossterm from versions 0.26/0.27 to 0.29
  • Replace atty::is(Stream::Stdin) with crossterm::event::is_tty(Stream::Stdin)

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
sshdconfig/Cargo.toml Remove atty dependency and update crossterm to 0.29
archive/registry/src/main.rs Replace atty usage with crossterm's is_tty function
archive/registry/Cargo.toml Remove atty dependency and update crossterm to 0.29

@SteveL-MSFT SteveL-MSFT merged commit 22b64f6 into PowerShell:main Aug 5, 2025
4 checks passed
@SteveL-MSFT SteveL-MSFT deleted the sshd-crate branch August 5, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant