IDE0290: Fix JsonObject structs/classes to use primary constructors

[ArmaanMcleod]

PR Summary

I have fixed some of the structs/classes in JsonObject to use primary constructors to simplify code.

Rule: https://learn.microsoft.com/en-gb/dotnet/fundamentals/code-analysis/style-rules/ide0290

Which is from csharp_style_prefer_primary_constructors which is set to true by default.

PR Context

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    - [ ] Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
      (which runs in a different PS Host).
      • Issue filed:
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
      • Issue filed:
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
      • Issue filed:
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).
      • Issue filed:

[iSazonov]

We would have to fix the entire codebase to make this rule mandatory. That would be a lot of work. I don't see the point in that.
But if this is recommended by default, contributors could use the new syntax for the new code.
I suggest to close the PR.
If you want to do something really useful in the area you could look our discussion about migrating from .globalconfig and Settings.StyleCop to .editorconfig. That would be really helpful.

[ArmaanMcleod]

We would have to fix the entire codebase to make this rule mandatory. That would be a lot of work. I don't see the point in that. But if this is recommended by default, contributors could use the new syntax for the new code. I suggest to close the PR. If you want to do something really useful in the area you could look our discussion about migrating from .globalconfig and Settings.StyleCop to .editorconfig. That would be really helpful.

@iSazonov Yeah wasn't sure with this one. I came across it but it seems like many files which need fixing when I did "Fix All", and some errors from moving some of the classes to primary constructors. I'll close the PR since this one seems less worth it than the other PR which provides performance gain.

[microsoft-github-policy-service]

📣 Hey @ArmaanMcleod, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Microsoft Forms