Fix child processes termination at exit after LoginGraceTime expires #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix child processes termination at exit after LoginGraceTime expires.
The fix forces termination of all existing child processes when the session process terminates after
LoginGraceTimeexpires. Child processes are terminated within anatexit()callback when the session process callsexit().The use of the non-async-signal-safe
exit()function is allowed here, because unlike Unix signals that interrupt execution at any point, user-mode APCs (the signal handling model used here) are queued to run when a thread voluntarily enters an alertable state (like SleepEx or WaitForSingleObjectEx).PR Context
Related to: