Open
Conversation
mukulpalol16
reviewed
Apr 3, 2024
Collaborator
mukulpalol16
left a comment
mukulpalol16
left a comment
There was a problem hiding this comment.
change the file name from Try_Catch.cpp to something more specific to our use case.
Poyam-ITT
requested changes
Apr 3, 2024
Try_Catch.cpp
Outdated
| @@ -0,0 +1,73 @@ | |||
| #include <iostream> | |||
Collaborator
There was a problem hiding this comment.
Please create separate files for better code structure
Try_Catch.cpp
Outdated
| } | ||
| }; | ||
|
|
||
| class AccidentHandler { |
Collaborator
There was a problem hiding this comment.
Can have a better name for this class instead of AccidentHandler
Try_Catch.cpp
Outdated
|
|
||
| class Car { | ||
| public: | ||
| void driveSafely(bool collision, bool brakeFailure) { |
Collaborator
There was a problem hiding this comment.
what if there are more exceptions/reasons for car accidents, then it wouldn't be the correct approach to pass the boolean values through parameters. can think of a better approach where we can handle multiple exceptions.
nansi-maheshwari-ITT
approved these changes
Apr 3, 2024
Poyam-ITT
reviewed
Apr 3, 2024
| bool collision = false; | ||
| bool brakeFailure = true; | ||
|
|
||
| if (collision) { |
Collaborator
There was a problem hiding this comment.
I am not able to figure out in which condition this code will process PersonInjuredException exception
nitintayal008
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.