Refactor

.clang-tidy

@@ -0,0 +1,18 @@
+Checks: >
+  readability-qt6-parent-child-check,
+  cppcoreguidelines*,
+  performance*,
+  readability-identifier-naming,
+  modernize-use-list-initialization,
+  -cppcoreguidelines-owning-memory,
+  -cppcoreguidelines-avoid-magic-numbers,
+  -cppcoreguidelines-non-private-member-variables-in-classes,
+  -cppcoreguidelines-special-member-functions,
+  -performance-enum-size,
+  -cppcoreguidelines-non-private-member-variables-in-classes
+
+HeaderFilterRegex: '.*'
+
+CheckOptions:
+  - key: modernize-use-list-initialization.StrictMode
+    value: 'true'

flake.nix

@@ -40,6 +40,8 @@
                 qt6.qtbase
                 qtcreator
 
+                python3
+                llvmPackages_latest.clang-tools
                 cmake
                 bear
                 entr

src/canvas/canvas.cpp

@@ -23,9 +23,9 @@
 #include <QScreen>
 
 // PUBLIC
-Canvas::Canvas(QWidget *parent) : QWidget{parent} {
+Canvas::Canvas(QWidget *parent) : QWidget{parent}, m_maxSize(m_sizeHint) {
     m_sizeHint = screen()->size() * m_scale;
-    m_maxSize = m_sizeHint;
+
 
     m_canvas = new QPixmap(m_sizeHint);
     m_overlay = new QPixmap(m_sizeHint);

src/canvas/canvas.hpp

@@ -26,7 +26,7 @@ class Canvas : public QWidget {
 
 public:
     explicit Canvas(QWidget *parent = nullptr);
-    ~Canvas();
+    ~Canvas() override;
 
     QPixmap *const canvas() const;
     QPixmap *const overlay() const;

src/command/command.hpp

@@ -22,6 +22,7 @@ class ApplicationContext;
 
 class Command {
 public:
+    virtual ~Command() = default;
     virtual void execute(ApplicationContext *context) = 0;
     virtual void undo(ApplicationContext *context) = 0;
 };

src/command/commandhistory.cpp

@@ -58,7 +58,7 @@ void CommandHistory::redo() {
     m_redoStack->pop_front();
 }
 
-void CommandHistory::insert(std::shared_ptr<Command> command) {
+void CommandHistory::insert(const std::shared_ptr<Command>& command) {
     while (!m_redoStack->empty()) {
         m_redoStack->pop_front();
     }

src/command/commandhistory.hpp

@@ -31,7 +31,7 @@ class CommandHistory {
 
     void undo();
     void redo();
-    void insert(std::shared_ptr<Command> command);
+    void insert(const std::shared_ptr<Command>& command);
 
     static constexpr int maxCommands{100};  // arbitrary
 

src/command/deselectcommand.cpp

@@ -18,23 +18,22 @@
 
 #include "deselectcommand.hpp"
 
+#include <utility>
+
 #include "../context/applicationcontext.hpp"
 #include "../context/coordinatetransformer.hpp"
 #include "../context/selectioncontext.hpp"
 #include "../context/spatialcontext.hpp"
 #include "../item/item.hpp"
 #include "../data-structures/cachegrid.hpp"
 
-DeselectCommand::DeselectCommand(QVector<std::shared_ptr<Item>> items) : ItemCommand{items} {}
-
-DeselectCommand::~DeselectCommand() {
-}
+DeselectCommand::DeselectCommand(QVector<std::shared_ptr<Item>> items) : ItemCommand{std::move(items)} {}
 
 void DeselectCommand::execute(ApplicationContext *context) {
     auto &selectedItems{context->selectionContext().selectedItems()};
 
     QRectF dirtyRegion{};
-    for (const auto item : m_items) {
+    for (const auto& item : m_items) {
         dirtyRegion |= item->boundingBox();
         selectedItems.erase(item);
     }
@@ -46,7 +45,7 @@ void DeselectCommand::undo(ApplicationContext *context) {
     auto &selectedItems{context->selectionContext().selectedItems()};
 
     QRectF dirtyRegion{};
-    for (const auto item : m_items) {
+    for (const auto& item : m_items) {
         dirtyRegion |= item->boundingBox();
         selectedItems.insert(item);
     }

src/command/deselectcommand.hpp

@@ -25,7 +25,6 @@ class ApplicationContext;
 class DeselectCommand : public ItemCommand {
 public:
     DeselectCommand(QVector<std::shared_ptr<Item>> items);
-    ~DeselectCommand();
 
     void execute(ApplicationContext *context) override;
     void undo(ApplicationContext *context) override;

src/command/groupcommand.cpp

@@ -18,6 +18,8 @@
 
 #include "groupcommand.hpp"
 
+#include <utility>
+
 #include "commandhistory.hpp"
 #include "selectcommand.hpp"
 #include "deselectcommand.hpp"
@@ -29,21 +31,18 @@
 #include "../data-structures/quadtree.hpp"
 #include "../item/group.hpp"
 
-GroupCommand::GroupCommand(QVector<std::shared_ptr<Item>> items) : ItemCommand{items} {
+GroupCommand::GroupCommand(QVector<std::shared_ptr<Item>> items) : ItemCommand{std::move(items)} {
     m_group = std::make_shared<GroupItem>();
 
     // sort according to z order
     ApplicationContext::instance()->spatialContext().quadtree().reorder(m_items);
 }
 
-GroupCommand::~GroupCommand() {
-}
-
 void GroupCommand::execute(ApplicationContext *context) {
     auto &quadtree{context->spatialContext().quadtree()};
     auto &selectedItems{context->selectionContext().selectedItems()};
 
-    for (const auto item : m_items) {
+    for (const auto& item : m_items) {
         quadtree.deleteItem(item, false);
     }
 
@@ -63,7 +62,7 @@ void GroupCommand::undo(ApplicationContext *context) {
     quadtree.deleteItem(m_group);
     selectedItems.clear();
 
-    for (const auto item : m_items) {
+    for (const auto& item : m_items) {
         selectedItems.insert(item);
         quadtree.insertItem(item, false);
     }

src/command/groupcommand.hpp

@@ -26,7 +26,6 @@ class GroupItem;
 class GroupCommand : public ItemCommand {
 public:
     GroupCommand(QVector<std::shared_ptr<Item>> items);
-    ~GroupCommand();
 
     void execute(ApplicationContext *context) override;
     void undo(ApplicationContext *context) override;

src/command/insertitemcommand.cpp

@@ -18,17 +18,16 @@
 
 #include "insertitemcommand.hpp"
 
+#include <utility>
+
 #include "../context/applicationcontext.hpp"
 #include "../context/coordinatetransformer.hpp"
 #include "../context/selectioncontext.hpp"
 #include "../context/spatialcontext.hpp"
 #include "../data-structures/cachegrid.hpp"
 #include "../data-structures/quadtree.hpp"
 
-InsertItemCommand::InsertItemCommand(QVector<std::shared_ptr<Item>> items) : ItemCommand{items} {
-}
-
-InsertItemCommand::~InsertItemCommand() {
+InsertItemCommand::InsertItemCommand(QVector<std::shared_ptr<Item>> items) : ItemCommand{std::move(items)} {
 }
 
 void InsertItemCommand::execute(ApplicationContext *context) {

src/command/insertitemcommand.hpp

@@ -24,7 +24,6 @@ class ApplicationContext;
 class InsertItemCommand : public ItemCommand {
 public:
     InsertItemCommand(QVector<std::shared_ptr<Item>> items);
-    ~InsertItemCommand();
 
     void execute(ApplicationContext *context) override;
     void undo(ApplicationContext *context) override;

src/command/itemcommand.cpp

@@ -19,8 +19,9 @@
 #include "itemcommand.hpp"
 
 #include <QDebug>
+#include <utility>
 
-ItemCommand::ItemCommand(QVector<std::shared_ptr<Item>> items) : m_items{items} {
+ItemCommand::ItemCommand(QVector<std::shared_ptr<Item>> items) : m_items{std::move(items)} {
 }
 
 ItemCommand::~ItemCommand() {

src/command/itemcommand.hpp

@@ -28,7 +28,7 @@ class Item;
 class ItemCommand : public Command {
 public:
     ItemCommand(QVector<std::shared_ptr<Item>> items);
-    ~ItemCommand();
+    ~ItemCommand() override;
 
 protected:
     QVector<std::shared_ptr<Item>> m_items;