Open
Conversation
Collaborator
deveeni
commented
Mar 6, 2022
deveeni
commented
- 등록화면 개발
- MUI 사용
beckyi
reviewed
Mar 19, 2022
src/EnrollRestaurant/Confirm.tsx
Outdated
| <Box> | ||
| {tagList && | ||
| tagList.map((tag: Tag, idx: number) => ( | ||
| <Chip label={tag.name} sx={{ ml: idx === 0 ? 0 : 1, mt: 1 }} /> |
| <Box> | ||
| {tagList.length > 0 && | ||
| tagList.map((tag: Tag) => | ||
| <Chip |
Contributor
There was a problem hiding this comment.
요기두 컴포넌트 여러개이므로 key 추가 부탁드려요~
| import SelectShare from "./SelectShare"; | ||
| import Confirm from "./Confirm"; | ||
|
|
||
| const theme = createTheme({ |
Contributor
There was a problem hiding this comment.
theme(ThemeProvider)를 최상단에서 감싸면 모든 페이지에 적용되서 관리하기 편할것 같아요!
src/EnrollRestaurant/SelectShare.tsx
Outdated
| renderValue={(selected: string[]) => { | ||
| let checkedList: string[] = []; | ||
|
|
||
| selected.forEach((selectedItem) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| selected.forEach((selectedItem) => { | |
| const checkedList = selected.map((selectedItem) => { |
Collaborator
Author
There was a problem hiding this comment.
왜 이런 방식을 추천해주신건가용? 이유가 있을까요 ?
Comment on lines
+79
to
+82
| {getStepContent(activeStep)} | ||
|
|
||
|
|
||
| {activeStep < steps.length - 1 ? ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.