Open
Conversation
beckyi
reviewed
Mar 19, 2022
Comment on lines
+40
to
+44
| let checkedList: string[] = []; | ||
|
|
||
| selected.forEach((selectedItem) => { | ||
| checkedList.push(SHARE_LIST[Number(selectedItem)].name) | ||
| }) |
Contributor
There was a problem hiding this comment.
Suggested change
| let checkedList: string[] = []; | |
| selected.forEach((selectedItem) => { | |
| checkedList.push(SHARE_LIST[Number(selectedItem)].name) | |
| }) | |
| const checkedList: string[] = selected.map((selectedItem) => { | |
| return SHARE_LIST[Number(selectedItem)].name | |
| }) |
beckyi
reviewed
Mar 19, 2022
| }} | ||
| > | ||
| {SHARE_LIST.map((item) => ( | ||
| <MenuItem value={item.id}> |
beckyi
reviewed
Mar 19, 2022
| 음식 종류 | ||
| </Grid> | ||
| <Grid item xs={9}> | ||
| {FOOD_TYPES[foodTypeId].name} |
Contributor
There was a problem hiding this comment.
Suggested change
| {FOOD_TYPES[foodTypeId].name} | |
| {FOOD_TYPES[foodTypeId]?.name} |
해당 값이 없을 때 오류가 발생할 수 있을 거 같아 예외 처리 해야할 것 같습니다.
beckyi
reviewed
Mar 19, 2022
| <Grid item xs={9}> | ||
| {price} 원 | ||
| </Grid> | ||
| {memo !== "" && ( |
Contributor
There was a problem hiding this comment.
Suggested change
| {memo !== "" && ( | |
| {memo && ( |
요렇게 해도 좋을거 같아요!
beckyi
reviewed
Mar 19, 2022
| <Grid item xs={9}> | ||
| <List> | ||
| {shareList.map((shareItem: string) => ( | ||
| <ListItem>{SHARE_LIST[Number(shareItem)].name} </ListItem> |
beckyi
reviewed
Mar 19, 2022
Comment on lines
+86
to
+87
| {tagList && | ||
| tagList.map((tag: Tag, idx: number) => ( |
Contributor
There was a problem hiding this comment.
Suggested change
| {tagList && | |
| tagList.map((tag: Tag, idx: number) => ( | |
| {tagList?.map((tag: Tag, idx: number) => ( |
beckyi
reviewed
Mar 19, 2022
| import SelectShare from "./SelectShare"; | ||
| import Confirm from "./Confirm"; | ||
|
|
||
| const theme = createTheme({ |
Contributor
There was a problem hiding this comment.
theme (ThemeProvider)를 최상단에서 관리하면 컴포넌트 별로 정의하지 않아도 되서 좋을 것 같아요!
deveeni
reviewed
Mar 26, 2022
| {tagList.length > 0 && | ||
| tagList.map((tag: Tag) => | ||
| <Chip | ||
| label={tag.name} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
맛집등록 UI 개발~~