-
Notifications
You must be signed in to change notification settings - Fork 292
Add SFT validation eval with val_data #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hallerite
merged 22 commits into
PrimeIntellect-ai:main
from
philippnormann:feature/sft-val-eval
Mar 10, 2026
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3cecc7d
Add SFT validation eval with val_data
philippnormann 03343f2
Fix SFT validation config safety and step alignment
philippnormann fbd6f90
Add optional eval-on-start for SFT validation
philippnormann f26ccbb
Fix SFT validation LoRA import and changelog entry
philippnormann 3c19f26
Fix SFT eval test imports after config move
philippnormann 3741a1f
refactor SFT validation config into single SFTValConfig
hallerite a34ca73
remove tests
hallerite bb6d3ea
factorize
hallerite aee17b5
remove eval_on_start
philippnormann 4ecfd60
require sft val data
philippnormann 9a3384d
handle ac
hallerite bf4b6dd
refactor
hallerite 0bcdb39
add option for val at start
hallerite b5cdc93
add back some stuff
hallerite c8a008c
Merge remote-tracking branch 'origin/main' into feature/sft-val-eval
hallerite a2f88f7
Merge remote-tracking branch 'origin/main' into feature/sft-val-eval
hallerite e49fd18
smarter gating
hallerite 47f3b30
smol fix
hallerite 67b828a
fix no-recompile
hallerite 4d3d4b8
make sure forward is compiled
hallerite 81fefe7
fix timing metric
hallerite d80bb23
Merge branch 'main' into feature/sft-val-eval
hallerite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.