Skip to content

fix: re-schedule empty trajectories to guarantee full groups #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsja merged 1 commit into from
Mar 11, 2026
Merged

fix: re-schedule empty trajectories to guarantee full groups #2014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/prime_rl/orchestrator/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,16 @@ async def generate_batch(self, step: int) -> list[vf.RolloutOutput]:
group = self.groups.get(group_id)
if group is None:
continue
group.completed_rollouts.append(finished_task.result())
rollout = finished_task.result()
if len(rollout["trajectory"]) == 0:
self.empty_rollouts_count += 1
group.rollouts_to_schedule += 1
self.logger.warning(
f"Empty trajectory in group {group_id}, re-scheduling "
f"({len(group.completed_rollouts)}/{self.rollouts_per_example} complete)"
)
continue
group.completed_rollouts.append(rollout)
if len(group.completed_rollouts) < self.rollouts_per_example:
continue
completed_rollouts = self.groups.pop(group_id).completed_rollouts
Expand All @@ -388,14 +397,6 @@ async def generate_batch(self, step: int) -> list[vf.RolloutOutput]:
self.buffer.update(completed_rollouts)
accepted_rollouts = self.buffer.sample_rollouts(n=self.rollouts_per_example)

empty_count = sum(1 for r in accepted_rollouts if len(r["trajectory"]) == 0)
if empty_count > 0:
self.logger.warning(
f"Filtered {empty_count}/{len(accepted_rollouts)} rollouts with empty trajectories"
)
accepted_rollouts = [r for r in accepted_rollouts if len(r["trajectory"]) > 0]
self.empty_rollouts_count += empty_count

batch_rollouts.extend(accepted_rollouts)
progress_increment = self.get_batch_progress_increment(accepted_rollouts)
batch_progress += progress_increment
Expand Down
Loading