pin images to cudnn cu128. this shold break ci because of the vllm de…#2451
Open
Jackmin801 wants to merge 1 commit intomainfrom
Open
pin images to cudnn cu128. this shold break ci because of the vllm de…#2451Jackmin801 wants to merge 1 commit intomainfrom
Jackmin801 wants to merge 1 commit intomainfrom
Conversation
Jackmin801
force-pushed
the
unify-ci-and-build-image
branch
from
987f9f0 to
0ef6200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fault being cu13
Note
Medium Risk
Changes the container runtime for GPU unit/integration and nightly workflows, which can break CI due to different preinstalled libraries (e.g., PyTorch) and CUDA/cuDNN compatibility.
Overview
Updates the GPU CI environment by replacing the
pytorch/pytorch:2.10.0-cuda13.0-cudnn9-develcontainer withnvidia/cuda:12.8.1-cudnn-devel-ubuntu22.04for GPU unit tests, GPU integration tests, and nightly experiments.This effectively pins workflows to CUDA 12.8 + cuDNN and removes reliance on the PyTorch-provided image, changing what system/ML dependencies are present at runtime.
Reviewed by Cursor Bugbot for commit 987f9f0. Bugbot is set up for automated code reviews on this repo. Configure here.