[Weight Transfer]: Support layerwise reloading for online quantization#2464
Open
S1ro1 wants to merge 5 commits into
Open
[Weight Transfer]: Support layerwise reloading for online quantization#2464S1ro1 wants to merge 5 commits into
S1ro1 wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0683bba. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Touches inference weight hot-reload and NCCL/filesystem broadcast flows; incorrect flag propagation or vLLM layerwise reload behavior could break online weight updates or degrade inference stability, especially under FP8 quantization.
Overview
Adds support for vLLM layerwise weight reloading during online inference weight updates, primarily to enable online FP8 quantization (
inference.quantization=fp8_per_block).Configuration is extended with
quantizationand aweight_broadcast.layerwiseflag (propagated/validated across trainer/orchestrator/inference), auto-enabling layerwise reload when quantization is set and forbidding incompatible combinations (e.g., layerwise vsquantize_in_weight_transfer).Inference weight update RPCs now carry the
layerwiseflag end-to-end (server → worker, and orchestrator →/init_broadcaster), and weight loading is refactored to a sharedload_weights_checkpoint_or_layerwisehelper that uses vLLM’sinitialize_layerwise_reload/finalize_layerwise_reloadplus a workaround to run FP8 online conversion withouttorch.compilewhen needed.Reviewed by Cursor Bugbot for commit 3974fd9. Bugbot is set up for automated code reviews on this repo. Configure here.