Fix: add layerwise as default#2467
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 718bbb8. Configure here.
Mirror the same fix as the NCCL path: replace `model.load_weights + process_weights_after_loading` with `load_weights_checkpoint_layerwise`. Without it, MoE + filesystem transport hits the same `Current vLLM config is not set` AssertionError at `worker/filesystem.py` on the first weight update. Verified end-to-end on Qwen3-30B-A3B-Thinking-2507 + reverse-text: filesystem broadcast returns 200 OK, orchestrator step 2 consumed new weights cleanly (off-policy level 1, reward 0.3583), trainer steady-state at ~29K tok/s, MFU 21%, no NaN, no errors.
hallerite
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes broken nccl weight transfer on vllm 0.20
Note
Medium Risk
Changes the hot weight-reload path for both filesystem and NCCL updates to use vLLM's layerwise reload APIs, which can affect runtime model correctness and stability during in-place updates. Risk is mitigated by keeping the kernel-format path intact and adding explicit MLA absorbed-weight recomputation for that path.
Overview
Switches checkpoint-format weight updates (filesystem and NCCL) to a new
load_weights_checkpoint_layerwiseflow that wrapsmodel.load_weights(...)with vLLMinitialize_layerwise_reload/finalize_layerwise_reloadandset_current_vllm_config, replacing the priorprocess_weights_after_loadingpostprocessing.For NCCL kernel-format transfers, removes the old generic postprocess step and instead explicitly calls
update_mla_absorbed_weightsafterload_weights_kernel, then returns early.Reviewed by Cursor Bugbot for commit 25f17df. Bugbot is set up for automated code reviews on this repo. Configure here.