-
Notifications
You must be signed in to change notification settings - Fork 284
feat: renderer-only multimodal path — rip MITO branch, pack pixel_values from renderer #2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hallerite
wants to merge
6
commits into
main
Choose a base branch
from
feat/multimodal-renderer-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a479a02
feat: drop use_renderer=True VLM skip; pack pixel_values from renderer
hallerite b385fbf
refactor(orchestrator): rip MITO multimodal path, renderer-only for VLMs
hallerite 24864bc
fix: align with renderer-multimodal PR surface (configs + deps + tests)
hallerite 1097ed2
chore: bump renderers + verifiers to latest feature-branch commits
hallerite bf26a06
chore: bump renderers + verifiers to pick up isinstance dispatch fix
hallerite 4c877be
chore: drop renderers git source, pin to released 0.1.7
hallerite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
configs/multimodal/rl_color_codeword_feat_renderer.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| # 20-step Qwen3-VL-4B RL run on color-codeword using the renderer multimodal path. | ||
| # | ||
| # Pair with rl_color_codeword_main_mito.toml for an A/B comparison: same env, | ||
| # same hyperparameters, same step count — only difference is the inference | ||
| # client. The feat-branch run uses the new RendererClient + Qwen3VLRenderer | ||
| # (renderers package with multimodal support); the main-branch baseline uses | ||
| # the existing TITO chat-completions path through the inference server. | ||
| # | ||
| # Compare in W&B project ``multimodal-renderer``: | ||
| # - ``kl/sampler_vs_trainer`` should be ~0 on this branch (the renderer | ||
| # produces byte-identical tokens to what the trainer re-tokenizes) and | ||
| # can spike on main when BPE drifts mid-rollout. | ||
| # - ``reward`` and ``loss`` should track within noise — same model, same | ||
| # env, same hyperparameters. | ||
| # - ``bridge_break_rate`` is renderer-only; surfaces multi-turn extension | ||
| # failures. | ||
|
|
||
| max_steps = 20 | ||
| seq_len = 4096 | ||
| output_dir = "outputs/rl_color_codeword_feat_renderer" | ||
| clean_output_dir = true | ||
| # Pure on-policy: inference can't run ahead of training, so every rollout | ||
| # is generated from the latest policy weights. Removes async/off-policy | ||
| # drift as a confound for the sampler-vs-trainer KL. | ||
| max_async_level = 0 | ||
|
|
||
| [model] | ||
| name = "Qwen/Qwen3-VL-4B-Instruct" | ||
|
|
||
| [model.vlm] | ||
| vision_encoder_attr = "model.visual" | ||
| language_model_attr = "model.language_model" | ||
|
|
||
| [deployment] | ||
| num_train_gpus = 1 | ||
| num_infer_gpus = 1 | ||
| gpus_per_node = 2 | ||
|
|
||
| [orchestrator] | ||
| batch_size = 16 | ||
| rollouts_per_example = 8 | ||
| use_renderer = true | ||
| use_token_client = false | ||
|
|
||
| # Track zero-advantage groups but don't drop them — we're validating the | ||
| # multimodal renderer path on 20 steps, not optimizing training efficiency. | ||
| # Step 0 on Qwen3-VL-4B vs color-codeword is likely uniform (all-correct or | ||
| # all-wrong) so enforce=True would crash before any training happens. | ||
| [[orchestrator.filters]] | ||
| type = "gibberish" | ||
|
|
||
| [[orchestrator.filters]] | ||
| type = "repetition" | ||
|
|
||
| [[orchestrator.filters]] | ||
| type = "zero_advantage" | ||
| enforce = false | ||
|
|
||
| [orchestrator.train.sampling] | ||
| max_completion_tokens = 64 | ||
|
|
||
| [[orchestrator.train.env]] | ||
| id = "color-codeword" | ||
| args = { images_per_turn = 2, max_turns = 2, num_examples = 100, seed = 42 } | ||
|
|
||
| [orchestrator.renderer] | ||
| name = "auto" | ||
| # 64 concurrent rollouts (batch_size=16 × rollouts_per_example=4) want | ||
| # more than one tokenizer slot to avoid serialization queueing. The | ||
| # image processor (CPU-bound) dominates for VLMs so returns diminish | ||
| # past 4; bump to 4 as the default for multimodal runs. | ||
| pool_size = 4 | ||
|
|
||
| [trainer] | ||
|
|
||
| [trainer.model] | ||
| optimization_dtype = "bfloat16" | ||
| reduce_dtype = "bfloat16" | ||
|
|
||
| [trainer.optim] | ||
| lr = 3e-6 | ||
|
|
||
| [inference] | ||
|
|
||
| [inference.model] | ||
| # Workaround for vLLM 0.20.1 Qwen3-VL deepstack buffer bug: when num_scheduled_tokens | ||
| # (188) gets padded up to the next cudagraph_capture_size (192), the model's | ||
| # _set_deepstack_input_embeds sizes the buffer to 188 but forward() runs with 192, | ||
| # triggering "Requested more deepstack tokens than available in buffer". Eager mode | ||
| # skips the padding so num_input_tokens == num_scheduled_tokens. | ||
| enforce_eager = true | ||
|
|
||
| [inference.parallel] | ||
| dp = 1 | ||
| tp = 1 | ||
|
|
||
| [wandb] | ||
| project = "multimodal-renderer" | ||
| name = "feat-renderer-20step-r8-i2-t2-onpolicy" | ||
| tags = ["qwen3vl-4b", "color-codeword", "renderer", "feat-branch", "mm-kwargs-generic", "on-policy"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking VLM config change missing from CHANGELOG
Medium Severity
The new
vlm_requires_renderervalidator makesorchestrator.use_renderer = truemandatory whenmodel.vlmis set. Previously, VLM configs useduse_renderer = false(the default). Any existing VLM config will now fail at load time with aValueError. This is a breaking configuration change (effectively a removed valid-config combination) that requires aCHANGELOG.mdentry per project rules.Triggered by project rule: BugBot Instructions
Reviewed by Cursor Bugbot for commit b385fbf. Configure here.