Skip to content

fix: resolve duplicate -g flag and type=bool argparse bug in sft.py #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vominh1919 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve duplicate -g flag and type=bool argparse bug in sft.py #1329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/sft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ def main(args):
parser.add_argument("--name-to-save", "-n", type=str, default="Qwen3-1.7B-Wordle")
parser.add_argument("--max-length", "-l", type=int, default=8192)
parser.add_argument("--per-device-train-batch-size", "-b", type=int, default=2)
parser.add_argument("--gradient-accumulation-steps", "-g", type=int, default=1)
parser.add_argument("--gradient-accumulation-steps", "-G", type=int, default=1)
parser.add_argument("--learning-rate", "-r", type=float, default=2e-5)
parser.add_argument("--num-train-epochs", "-e", type=int, default=3)
parser.add_argument("--weight-decay", "-w", type=float, default=0.01)
parser.add_argument("--max-grad-norm", "-g", type=float, default=0.1)
parser.add_argument("--push-to-hub", "-p", type=bool, default=True)
parser.add_argument("--push-to-hub", "-p", action=argparse.BooleanOptionalAction, default=True)
Copy link
Copy Markdown

@cursor cursor Bot May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsed push_to_hub value never used in SFTConfig

High Severity

The --push-to-hub argparse fix is incomplete. While the CLI now correctly parses --no-push-to-hub via BooleanOptionalAction, the SFTConfig on line 49 hardcodes push_to_hub=True instead of using args.push_to_hub. This means --no-push-to-hub is silently ignored — the model is always pushed to the hub regardless of the flag.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d2ae717. Configure here.

args = parser.parse_args()
main(args)