Tighten v1 config, bindings, and handler typing#1362
Merged
Conversation
018fae2 to
1afa6ab
Compare
…-composability # Conflicts: # tests/test_save_utils.py # tests/test_v1_runtime_lifecycle.py # verifiers/v1/packages/harnesses/opencode.py # verifiers/v1/utils/lifecycle_utils.py
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1235c06. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
objectusage by introducing named types and protocols for runtime handles, prompts, tool specs, and config refs[env.args], binding behavior, and subagent/rlm composabilityTesting
ty check verifiers/v1passedruff checkpassedpre-commit run --all-filespassedNote
Medium Risk
Medium risk because it adds new CI-enforced Semgrep rules and updates multiple shipped environment examples to the stricter v1 config/bindings/message typing, which could break downstream example usage if assumptions differ.
Overview
Adds a Semgrep policy gate to CI and pre-commit (new
semgrep-v1-policyhook,style.ymljob, and.semgrep/verifiers.ymlrules) to enforce stricter v1 typing and API style (e.g., no rawAny/Mappingin v1/env code, typedget_messages, config-annotation constraints).Tightens v1 environment/config patterns across docs and examples: updates
load_environmentsignatures to requireconfig: vf.EnvConfig, shifts examples fromimport verifiers.v1 as vftoimport verifiers as vf, standardizes message access viavf.get_messages(...), and moves shared extraction logic into tasksetobjects+bindings(and updates docs to emphasize explicit rollout logic).Refactors several example environments to match the new contracts (notably
bfcl_v3,hello_rlm_v1now usingvf.RLM/vf.RLMConfig,hello_subagent_v1object/binding usage,opencode_harborsimplified to directvf.HarborTaskset/vf.OpenCode, plus OpenEnv prompt renderers converted to callable classes) and updates OpenEnv bundled projects toopenenv-core>=0.3.0and revised build guidance.Reviewed by Cursor Bugbot for commit a490014. Bugbot is set up for automated code reviews on this repo. Configure here.