Skip to content

server: clear slot state on task cancellation #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: prism
Choose a base branch
from
Draft

server: clear slot state on task cancellation #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36012a2
Initial plan
Copilot Jul 31, 2026
ef1571d
Apply remaining changes
Copilot Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/server/server-context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ struct server_slot {
prompt.tokens.insert(spec_draft);
}

void release() {
void release(bool clear_prompt = false) {
if (is_processing()) {
GGML_ASSERT(task);

Expand All @@ -453,7 +453,7 @@ struct server_slot {
state = SLOT_STATE_IDLE;

// do not keep context of the child slots - the parent's context is enough
if (task->is_child()) {
if (clear_prompt || task->is_child()) {
prompt_clear(false);
}
Comment on lines +456 to 458

Expand Down Expand Up @@ -2274,10 +2274,10 @@ struct server_context_impl {
} break;
case SERVER_TASK_TYPE_CANCEL:
{
// release slot linked with the task id
// release slot linked with the task id; cancelled requests should drop the slot state
for (auto & slot : slots) {
if (slot.task && slot.task->id == task.id_target) {
slot.release();
slot.release(true);
break;
}
}
Expand Down