Skip to content

metal: default-on nr1=2 multi-column Q2_0 matvec (spec-decode verify) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bri-prism merged 1 commit into from
Jul 14, 2026
Merged

metal: default-on nr1=2 multi-column Q2_0 matvec (spec-decode verify) #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ggml/src/ggml-metal/ggml-metal-device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,13 @@ ggml_metal_pipeline_with_params ggml_metal_library_get_pipeline_mul_mv(ggml_meta
if (nr1_force > 1 && ne11 >= 2) {
nr1 = std::min(nr1_force, 4);
suffix = nr1 == 2 ? "_nr1_2" : nr1 == 3 ? "_nr1_3" : "_nr1_4";
} else if (nr1_max != 1 && ne11 >= 2 && ne11 != 3) {
// Default-on nr1=2 multi-column (mirrors the Q1_0 path above):
// measured +31% at ne11=2 (93.2 vs 122 us) and a win at ne11=4
// (2 passes, 171 vs 183). ne11==3 is carved out -- that is the
// occupancy cliff (nr1_3 loses to ext) that kept this opt-in;
// for 3 columns we stay on ext. GGML_METAL_Q2_0_NR1=1 disables.
nr1 = 2; suffix = "_nr1_2";
}
} break;
case GGML_TYPE_Q4_0:
Expand Down
Loading