Test/crypto utilities 2616 - #2690
Closed
desireddymohithreddy0925 wants to merge 8 commits into
Closed
Conversation
added 6 commits
June 22, 2026 18:08
desireddymohithreddy0925
requested a review
from Priyanshu-byte-coder
as a code owner
June 22, 2026 17:58
GSSoC Label Checklist 🏷️@Umbrella-io — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2616
Summary of Changes
Added comprehensive Vitest unit tests for the exported utility functions in
src/lib/crypto.ts, completely encompassing token encryption/decryption flows as well as webhook signature validation.Details:
encryptToken/decryptTokenRoundtrip Tests:process.env.ENCRYPTION_KEYusingbeforeEach/afterEachlifecycle hooks to isolate tests without side effects.encryptTokenaccurately returns an object populated with valid, non-empty hex strings for both theencryptedpayload and the Initialization Vector (iv).decryptTokenperfectly restores the original plaintext from validly encrypted ciphertext.decryptTokenexplicitly rejects (returnsnullwithout crashing) tampered ciphertexts and invalid IVs (wrong lengths or formatting).safeCompareTiming Attack Protection Tests:hellovshello world).Signature Helper Tests (
getExpectedSignature/verifyGitHubSignature):getExpectedSignaturecleanly creates an accurate HMAC-SHA256 signature string matching GitHub'ssha256=prefixed format.verifyGitHubSignatureapproves valid signatures and correctly rejects invalid signatures, manipulated request bodies, missing prefixes, andnullsignature inputs.Impact
safeComparefrom vulnerabilities like length-leaking timing attacks.