Fix inconsistent timezone handling in contributions API and StreakCalendar - #3237
Open
saurabhhhcodes wants to merge 2 commits into
Open
Fix inconsistent timezone handling in contributions API and StreakCalendar#3237saurabhhhcodes wants to merge 2 commits into
saurabhhhcodes wants to merge 2 commits into
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1: Mixed timezone handling in contributions API route
fetchContributionsForAccountusedtoLocalDateStr()(local timezone) to format thesincedate for the GitHub API query, while every other route usestoISOString().slice(0, 10)(UTC). For users in negative UTC offsets this caused a one-day shift in the query window, making streak and contribution data disagree on which dates to include. Fixed by removingtoLocalDateStrand usingsince.toISOString().slice(0, 10)consistently with the rest of the codebase.Bug 2: StreakCalendar used local dates to look up UTC-keyed contribution data
The
StreakCalendarcomponent usedtoLocalDateStr()(local timezone) to construct the lookup key into the contribution data, but the data keys come from GitHub's API which always returns UTC dates (item.commit.author.date.slice(0, 10)). This caused commits to appear on wrong calendar cells for users whose local date differs from UTC. Fixed by renaming totoUtcDateStrand usingtoISOString().slice(0, 10)for both lookup and isToday comparison.