You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score
Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus
Closing — this change is incorrect and would introduce a bug.
- return Array.from(reposSet).sort();+ return Array.from(reposSet).sort((a, b) => a - b);
reposSet, langsSet and events all hold strings. (a, b) => a - b is a numeric comparator — subtracting two strings yields NaN, so the comparator always returns NaN and the sort order becomes unspecified. The default .sort() (lexicographic) is the correct behavior for strings.
This matters beyond ordering: eventsKey = [...events].sort().join(",") is used as a cache key, so a non-deterministic sort would break cache stability.
Also note #3299 and #3300 are identical to each other — please don't open the same change twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.