Skip to content

fix: code quality and safety improvements - #3299

Closed
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-84165
Closed

fix: code quality and safety improvements#3299
saurabhhhcodes wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
saurabhhhcodes:fix/devtrack-84165

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels Jul 31, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@github-actions github-actions Bot added type:feature GSSoC type bonus: new feature type:design GSSoC type bonus: UI/design (+10 pts) type:performance GSSoC type bonus: performance (+15 pts) labels Jul 31, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder added the gssoc:invalid GSSoC: Invalid contribution label Jul 31, 2026
@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

Closing — this change is incorrect and would introduce a bug.

- return Array.from(reposSet).sort();
+ return Array.from(reposSet).sort((a, b) => a - b);

reposSet, langsSet and events all hold strings. (a, b) => a - b is a numeric comparator — subtracting two strings yields NaN, so the comparator always returns NaN and the sort order becomes unspecified. The default .sort() (lexicographic) is the correct behavior for strings.

This matters beyond ordering: eventsKey = [...events].sort().join(",") is used as a cache key, so a non-deterministic sort would break cache stability.

Also note #3299 and #3300 are identical to each other — please don't open the same change twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:invalid GSSoC: Invalid contribution gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:feature GSSoC type bonus: new feature type:performance GSSoC type bonus: performance (+15 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants